Skip to content

Release 1.0.21 - #163

Merged
lollox80 merged 1 commit into
mainfrom
release/1.0.21
Oct 6, 2026
Merged

lollox80 merged 1 commit into
mainfrom
release/1.0.21

Conversation

@lollox80

@lollox80 lollox80 commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

Release 1.0.21: 11 PRs merged since v1.0.20 (#150-#152, #154-#160, #162; #154 has Changelog: none). #161 is not in this release.

Tested on Windows 11, Python 3.13: CHECK VERDE: release/1.0.21 (d828963) | ruff pulito | 2236 passed, 14 skipped | copertura 97.15% (soglia 95%)

Field test on the intercom: done after this merge and before the release is published (ADR-19). The merge commit is deployed on the development HA, an outside view is opened on the 40507 (local UDP), and the debug log is checked for the plant's real IP, SIP id, GID, MAC and domain: none may appear. The train has no SIP, media, door or transport change; the test is about the log masking of #157/#159 on a real plant.

Changelog: none

🤖 Generated with Claude Code

Version 1.0.21 in the manifest and its CHANGELOG section, composed by
tools/release_notes.py from the Changelog lines of the 11 PRs merged
since v1.0.20: plant data masked in the logs (#157, #159), the Windows
symlink case of the away message upload (#160), troubleshooting and
phonebook docs (#156, #158, #162), CI and tooling.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@lollox80
lollox80 added this pull request to the merge queue Oct 6, 2026
Merged via the queue into main with commit 1ba3f21 Oct 6, 2026
13 checks passed
@lollox80
lollox80 deleted the release/1.0.21 branch October 6, 2026 23:13
@Apeiv

Apeiv commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

Tested on a 40515 on the cloud (TLS + SRTP), main at 1ba3f21.

Check Result
Test suite (full / media / browser) pass: 2161 / 15 / 86
Loads, registered, clean log, card served, /av passive pass
Outside view, 4 calls, 17 to 21 s each pass: video OK, SRTP failures 0, audio both ways
Photo during the call first JPEG 0.8 s after the grabber started, the street, clean

Your own test covers a 40507 on local UDP, so I spent most of the time on what only the cloud setup shows: the masking. Debug log on for all four calls, then I searched the raw text for every real value of this plant. None showed up in clear:

Plant data Masked as
Our SIP id id…NN#xxxx in From/To/Contact
SIP domain (with the Tab's MAC in it) domain#xxxx
Tab's LAN IP 192.x.x.N in Route/Via
Home public IP masked in received=, Contact, Route
Device UUID uuid#xxxx
Authorization, SRTP keys ***

The MAC on its own, GID, IMEI and MyName didn't appear during calls.

One gap on 40515 cloud plants: the phone ids here are 5 digits (6xxxx), the same length as a panel extension. Ours is masked because it is registered, but another phone's id stays readable as a URI user, since _URI_USER only takes ids longer than _PANEL_EXT_MAX. redact_plant() on <sip:6xxxx@…> returns it unmasked. It didn't leak today, but it would in an INVITE or MESSAGE from another phone. Same thing one place over: _mask_field leaves a 5-digit SIP_ID readable, so a phonebook row for another phone would show it too. Masking 5-digit ids that aren't the panel's own extension would close both. Happy to open a PR.

Not plant data: the Vimar relay address shows in full in the media lines (First SRTP, First video RTP, RTCP) and in the SDP. It's Vimar's server, fine to leave.

Still to do by hand: a ring answered from the card on iPhone, Echo via Scrypted, the door message. I'll add them here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants