You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right, most of these are going to be tiny on their own, or will depend on the specific code being compiled repeating this pattern.
I still think changes like this in pattern matching simple code is worth it - we're adding a single if in an edge case, and DCE is specifically designed to converge in a single pass (though other optimizations can interact with it and require another later pass). The theory is that if we find other code later that can be rewritten trivially to false/true, we will get to propagate that out and clean up other code - and now that will even work if the boolean is trapped in a multiexpr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #10261 (see comments in that PR for discussion).
Fixes #10278