Run OptimizedOnlyCompilerSuite when draft is disabled#10254
Run OptimizedOnlyCompilerSuite when draft is disabled#10254niloc132 wants to merge 3 commits intogwtproject:mainfrom
Conversation
Somehow this suite was permenently disabled, and one test has broken in the meantime due to String.contains being simplified to the point it can more easily be inlined. When gwtproject#10147 is fixed, this can be re-enabled. Fixes gwtproject#10253
|
With the current setup this won't run in CI. Would it be worth it to run this suite e.g. in a separate |
Ah, that's no good. It'll increase the build time, but I think worth it to get the For what its worth, I usually run |
|
Maybe the CI could run draft tests with Java 11, 17, 22 and optimized tests on Java 21? |
zbynek
left a comment
There was a problem hiding this comment.
Being able to run it locally is an improvement worth merging. CI changes may need a separate PR.
|
I tweaked the github actions wiring to also run optimized tests, now running at https://github.com/niloc132/gwt/actions/runs/23264900880/job/67642962566 We could make them mutually exclusive, but I'd really like to also eventually add various browser tests via selenium, as we have a few failures there (and it would help catch some changes like #10292). |
|
...Excitingly, the |
Somehow this suite was permanently disabled, and one test has broken in the meantime due to String.contains being simplified to the point it can more easily be inlined. When #10147 is fixed, this can be re-enabled.
Fixes #10253