Skip to content

Run OptimizedOnlyCompilerSuite when draft is disabled#10254

Open
niloc132 wants to merge 3 commits intogwtproject:mainfrom
niloc132:10253-run-optimized-only-suite
Open

Run OptimizedOnlyCompilerSuite when draft is disabled#10254
niloc132 wants to merge 3 commits intogwtproject:mainfrom
niloc132:10253-run-optimized-only-suite

Conversation

@niloc132
Copy link
Copy Markdown
Member

Somehow this suite was permanently disabled, and one test has broken in the meantime due to String.contains being simplified to the point it can more easily be inlined. When #10147 is fixed, this can be re-enabled.

Fixes #10253

Somehow this suite was permenently disabled, and one test has broken in
the meantime due to String.contains being simplified to the point it can
more easily be inlined. When gwtproject#10147 is fixed, this can be re-enabled.

Fixes gwtproject#10253
@niloc132 niloc132 added this to the 2.14 milestone Jan 24, 2026
@niloc132 niloc132 added the ready This PR has been reviewed by a maintainer and is ready for a CI run. label Jan 24, 2026
@niloc132 niloc132 requested review from vegegoku and zbynek February 11, 2026 21:20
@zbynek
Copy link
Copy Markdown
Collaborator

zbynek commented Feb 17, 2026

With the current setup this won't run in CI. Would it be worth it to run this suite e.g. in a separate ant invocation in full-check, that would only run in optimized HTMLUnit?

@niloc132
Copy link
Copy Markdown
Member Author

With the current setup this won't run in CI. Would it be worth it to run this suite e.g. in a separate ant invocation in full-check, that would only run in optimized HTMLUnit?

Ah, that's no good. It'll increase the build time, but I think worth it to get the test.web.htmlunit restored. Probably should look into test.nometa.htmlunit as well...

For what its worth, I usually run ant test.draft.htmlunit test.web.htmlunit locally so it fails slightly faster if there is something egregiously wrong, but then also runs through the optimized version as well to be sure prod builds won't suffer too.

@zbynek
Copy link
Copy Markdown
Collaborator

zbynek commented Feb 28, 2026

Maybe the CI could run draft tests with Java 11, 17, 22 and optimized tests on Java 21?

vegegoku
vegegoku previously approved these changes Mar 11, 2026
zbynek
zbynek previously approved these changes Mar 11, 2026
Copy link
Copy Markdown
Collaborator

@zbynek zbynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being able to run it locally is an improvement worth merging. CI changes may need a separate PR.

@niloc132 niloc132 dismissed stale reviews from zbynek and vegegoku via e8e93a3 March 18, 2026 20:11
@niloc132
Copy link
Copy Markdown
Member Author

I tweaked the github actions wiring to also run optimized tests, now running at https://github.com/niloc132/gwt/actions/runs/23264900880/job/67642962566

+ ant clean test dist doc '-Dtest.jvmargs=-ea -Dgwt.watchFileChanges=false' -Dtest.web.htmlunit.disable=false -Dtest.nometa.htmlunit.disable=true -Dtest.emma.htmlunit.disable=true

We could make them mutually exclusive, but I'd really like to also eventually add various browser tests via selenium, as we have a few failures there (and it would help catch some changes like #10292).

@niloc132
Copy link
Copy Markdown
Member Author

...Excitingly, the test.*.disable flags seem to not booleans, but trigger if they are present at all, regardless of value (including blank).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready This PR has been reviewed by a maintainer and is ready for a CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OptimizedOnlyCompilerSuite is never run, fails

3 participants