state updates

client/lib/gumnut/floor.test.ts

@@ -1,7 +1,7 @@
 import test from 'node:test';
 import * as assert from 'node:assert';
 import { GumnutFloor } from './floor.ts';
-import { stringToArray } from '../ymodel/helper.ts';
+import { stringToArray } from '../shared/array.ts';
 
 test('floor server changes', () => {
   const f = new GumnutFloor();

client/lib/gumnut/floor.ts

@@ -5,7 +5,7 @@ import { encodePatch, type Patch, type WirePatch, decodePatch } from '../ymodel/
 import { InoPosRef, InoPosRefImpl, type GumnutData } from './types.ts';
 import type { PatchApi } from '../ymodel/work-holder.ts';
 import type { RangeUpdate } from '../ymodel/internal/range.ts';
-import { arrayToString } from '../ymodel/helper.ts';
+import { arrayToString } from '../shared/array.ts';
 import { decodeGumnutDataArray, encodeGumnutDataArray } from './wire.ts';
 
 type WireType = {
@@ -209,9 +209,9 @@ export class GumnutFloor {
     };
   }
 
-  resolveRef(r: InoPosRef) {
+  resolveRef(r: InoPosRef): number {
     const impl = r as InoPosRefImpl;
-    return this.low.byIno(impl.target).posOf(impl.id);
+    return this.low.byIno(impl.target).idToPos(impl.id).pos;
   }
 
   perform(fn: FloorFn): InoChanges {
@@ -225,7 +225,7 @@ export class GumnutFloor {
         },
         resolveRef(r) {
           const impl = r as InoPosRefImpl;
-          return byIno(impl.target).posOf(impl.id);
+          return byIno(impl.target).idToPos(impl.id).pos;
         },
       };
       yield* fn(api);

client/lib/gumnut/wire.ts

@@ -1,4 +1,4 @@
-import { stringToArray } from '../ymodel/helper.ts';
+import { stringToArray } from '../shared/array.ts';
 import type { Id } from '../ymodel/internal/shared.ts';
 import { emptySymbol, InoPosRefImpl, type GumnutData } from './types.ts';
 

client/lib/shared/array.test.ts

@@ -0,0 +1,61 @@
+import test from 'node:test';
+import * as assert from 'node:assert';
+import { arrayToString, hasIndex } from './array.ts';
+
+test('hole', () => {
+  const x = new Array(5);
+
+  x[0] = undefined;
+
+  assert.ok(!hasIndex(x, 1));
+  assert.ok(hasIndex(x, 0));
+
+  assert.ok(!hasIndex(x, 10000));
+
+  assert.ok(!hasIndex(x, 0.1));
+  assert.ok(!hasIndex(x, -1));
+  assert.ok(!hasIndex(x, NaN));
+  assert.ok(!hasIndex(x, Infinity));
+  assert.ok(!hasIndex(x, -Infinity));
+});
+
+test('arrayToString', () => {
+  assert.strictEqual(arrayToString(['Z']), '\0');
+  assert.strictEqual(arrayToString([true, false, Infinity]), '\x01\0\0');
+  assert.strictEqual(arrayToString([32.5, NaN]), ' \0');
+  assert.strictEqual(arrayToString([null]), '\0');
+
+  // check toPrimitive
+  class Foo {
+    [Symbol.toPrimitive]() {
+      return 123; // '{'
+    }
+  }
+  assert.strictEqual(arrayToString([new Foo()]), '{');
+
+  // check boring class
+  class Bar {}
+  assert.strictEqual(arrayToString([new Bar()]), '\0');
+
+  // check bigint throws
+  assert.throws(() => {
+    arrayToString([1234n]);
+  });
+
+  // check symbol throws
+  assert.throws(() => {
+    arrayToString([Symbol('blah')]);
+  });
+
+  // check symbol throws
+  assert.throws(() => {
+    arrayToString([Symbol.for('blah')]);
+  });
+
+  // this is `number & 0xffff` semantics in JS - clamp to uint16
+  const s = arrayToString([-100_000_000]);
+  assert.strictEqual(s.length, 1);
+  assert.strictEqual(s, String.fromCodePoint(7936));
+  assert.strictEqual(arrayToString([-100_000_000.99]), s);
+  assert.strictEqual(arrayToString([-100_000_000.00001]), s);
+});