Repository navigation
[INFRA-19] Keep a stream host path prefix on voice origin calls - #96
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In Gumloop sandboxes the SDK will reach the stream host through the orchestrator's credential proxy, at
GUMLOOP_STREAM_BASE_URL=http://192.0.2.1/bound/gumloop-ws/api/v1. Voice session start and end usepost_to_stream_host(origin=True), which replaced the whole base path with/gummies/.... That dropped/bound/gumloop-ws, so those calls would land on the proxy's API and get a 404.origin=Truenow strips only a trailing/api/v1and keeps any prefix mounted above it. Otherwise nothing changes:https://ws.gumloop.com/api/v1still resolves to the host root, and a custom base like/custom/v2still resolves to the root, as the existing test expects.The sandbox template pins
gumloop==0.5.6; it needs a release with this fix and a template bump before the backend turns on the proxy for SDK calls.Part of INFRA-19
Test plan
test_voice_keeps_a_path_prefix_mounted_above_api_v1(sync and async).scripts/check: ruff format, ruff, pyright, uv lock check, and pytest (872 passed; the 19 errors aretests/integration/test_live.py, which needs live credentials).Raised from
ws-rbehalMade with Cursor
Need help on this PR? Tag
@codesmith-botwith what you need.