Skip to content

chore: Use node: scheme for stdlib imports - #19

Merged
phated merged 1 commit into
mainfrom
phated/node-imports
Oct 13, 2026
Merged

phated merged 1 commit into
mainfrom
phated/node-imports

Conversation

@phated

@phated phated commented Sep 28, 2026

Copy link
Copy Markdown
Member

Node added the node: scheme for stdlib packages. We should switch to that to ensure npm packages named the same aren't loaded accidentally.

@phated
phated requested a review from FotoVerite September 28, 2026 20:14
Comment thread index.js Resolved

@FotoVerite FotoVerite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are you're feelings on warnings in general are they worth flagging?

@phated

phated commented Oct 13, 2026

Copy link
Copy Markdown
Member Author

What are you're feelings on warnings in general are they worth flagging?

Warnings are just warnings. We can clean them up or ignore. Failures are things that will actually cause bugs.

@phated
phated merged commit 0895a64 into main Oct 13, 2026
10 checks passed
@phated
phated deleted the phated/node-imports branch October 13, 2026 21:07
@phated phated added this to v6 Oct 15, 2026
@phated phated moved this to Done in v6 Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants