-
Notifications
You must be signed in to change notification settings - Fork 34
feat(advisory): implement CSAF Vulnerabilities tab with per-CVE cards #1069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
CryptoRodeo
wants to merge
4
commits into
guacsec:main
Choose a base branch
from
CryptoRodeo:TC-4621
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
feec631
feat(advisory): add CSAF 2.0 types, query hook, and ECharts dependency
CryptoRodeo 4db37d1
feat(advisory): add CSAF type detection and conditional 5-tab layout
CryptoRodeo 6452ecb
feat(advisory): implement CSAF Vulnerabilities tab with per-CVE cards
CryptoRodeo 88f74e8
fix(advisory): fix frozen ExpandableSections, severity cast, and unus…
CryptoRodeo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 51 additions & 0 deletions
51
client/src/app/pages/advisory-details/components/csaf-cvss-details.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| /** Expandable CVSS v3 breakdown showing all scoring metrics. */ | ||
| import React from "react"; | ||
|
|
||
| import { | ||
| DescriptionList, | ||
| DescriptionListDescription, | ||
| DescriptionListGroup, | ||
| DescriptionListTerm, | ||
| ExpandableSection, | ||
| } from "@patternfly/react-core"; | ||
|
|
||
| import type { CsafCvssV3 } from "@app/types/csaf"; | ||
|
|
||
| interface CsafCvssDetailsProps { | ||
| cvss: CsafCvssV3; | ||
| } | ||
|
|
||
| export const CsafCvssDetails: React.FC<CsafCvssDetailsProps> = ({ cvss }) => { | ||
| const [isExpanded, setIsExpanded] = React.useState(false); | ||
|
|
||
| const metrics: { label: string; value?: string }[] = [ | ||
| { label: "Attack Vector", value: cvss.attackVector }, | ||
| { label: "Attack Complexity", value: cvss.attackComplexity }, | ||
| { label: "Privileges Required", value: cvss.privilegesRequired }, | ||
| { label: "User Interaction", value: cvss.userInteraction }, | ||
| { label: "Scope", value: cvss.scope }, | ||
| { label: "Confidentiality Impact", value: cvss.confidentialityImpact }, | ||
| { label: "Integrity Impact", value: cvss.integrityImpact }, | ||
| { label: "Availability Impact", value: cvss.availabilityImpact }, | ||
| { label: "Vector String", value: cvss.vectorString }, | ||
| ]; | ||
|
|
||
| return ( | ||
| <ExpandableSection | ||
| toggleText={isExpanded ? "Hide CVSS details" : "Show CVSS details"} | ||
| onToggle={(_event, expanded) => setIsExpanded(expanded)} | ||
| isExpanded={isExpanded} | ||
| > | ||
| <DescriptionList isHorizontal isCompact> | ||
| {metrics | ||
| .filter((m) => m.value) | ||
| .map((m) => ( | ||
| <DescriptionListGroup key={m.label}> | ||
| <DescriptionListTerm>{m.label}</DescriptionListTerm> | ||
| <DescriptionListDescription>{m.value}</DescriptionListDescription> | ||
| </DescriptionListGroup> | ||
| ))} | ||
| </DescriptionList> | ||
| </ExpandableSection> | ||
| ); | ||
| }; |
157 changes: 157 additions & 0 deletions
157
client/src/app/pages/advisory-details/components/csaf-remediations.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,157 @@ | ||
| /** Remediations section grouped by category with expandable product lists. */ | ||
| import React from "react"; | ||
|
|
||
| import { | ||
| Card, | ||
| CardBody, | ||
| CardTitle, | ||
| ExpandableSection, | ||
| Flex, | ||
| FlexItem, | ||
| Label, | ||
| List, | ||
| ListItem, | ||
| } from "@patternfly/react-core"; | ||
| import ExternalLinkAltIcon from "@patternfly/react-icons/dist/esm/icons/external-link-alt-icon"; | ||
|
|
||
| import type { CsafRemediation } from "@app/types/csaf"; | ||
|
|
||
| interface CsafRemediationsProps { | ||
| remediations: CsafRemediation[]; | ||
| productNameMap: Map<string, string>; | ||
| } | ||
|
|
||
| /** Groups remediations by category. */ | ||
| function groupByCategory( | ||
| remediations: CsafRemediation[], | ||
| ): Map<string, CsafRemediation[]> { | ||
| const groups = new Map<string, CsafRemediation[]>(); | ||
| for (const rem of remediations) { | ||
| const existing = groups.get(rem.category); | ||
| if (existing) { | ||
| existing.push(rem); | ||
| } else { | ||
| groups.set(rem.category, [rem]); | ||
| } | ||
| } | ||
| return groups; | ||
| } | ||
|
|
||
| /** Renders text with URLs converted to links. */ | ||
| const LinkifiedText: React.FC<{ text: string }> = ({ text }) => { | ||
| const urlRegex = /(https?:\/\/[^\s)]+)/g; | ||
| const parts = text.split(urlRegex); | ||
| return ( | ||
| <> | ||
| {parts.map((part, i) => | ||
| urlRegex.test(part) ? ( | ||
| <a | ||
| key={`link-${i}`} | ||
| href={part} | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| > | ||
| {part} <ExternalLinkAltIcon /> | ||
| </a> | ||
| ) : ( | ||
| <span key={`text-${i}`}>{part}</span> | ||
| ), | ||
| )} | ||
| </> | ||
| ); | ||
| }; | ||
|
|
||
| /** Single remediation card within a category group. */ | ||
| const RemediationCard: React.FC<{ | ||
| remediation: CsafRemediation; | ||
| productNameMap: Map<string, string>; | ||
| }> = ({ remediation, productNameMap }) => { | ||
| const [showProducts, setShowProducts] = React.useState(false); | ||
| const productIds = remediation.product_ids || []; | ||
|
|
||
| return ( | ||
| <Card isPlain isCompact> | ||
| <CardBody> | ||
| <Flex direction={{ default: "column" }} gap={{ default: "gapSm" }}> | ||
| <FlexItem> | ||
| <LinkifiedText text={remediation.details} /> | ||
| </FlexItem> | ||
| {remediation.url && ( | ||
| <FlexItem> | ||
| <a | ||
| href={remediation.url} | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| > | ||
| {remediation.url} <ExternalLinkAltIcon /> | ||
| </a> | ||
| </FlexItem> | ||
| )} | ||
| {productIds.length > 0 && ( | ||
| <FlexItem> | ||
| <ExpandableSection | ||
| toggleText={ | ||
| showProducts | ||
| ? "Hide affected products" | ||
| : `Show ${productIds.length} affected products` | ||
| } | ||
| onToggle={(_event, expanded) => setShowProducts(expanded)} | ||
| isExpanded={showProducts} | ||
| > | ||
| <List isPlain> | ||
| {productIds.map((pid) => ( | ||
| <ListItem key={pid}> | ||
| {productNameMap.get(pid) || pid} | ||
| </ListItem> | ||
| ))} | ||
| </List> | ||
| </ExpandableSection> | ||
| </FlexItem> | ||
| )} | ||
| </Flex> | ||
| </CardBody> | ||
| </Card> | ||
| ); | ||
| }; | ||
|
|
||
| export const CsafRemediations: React.FC<CsafRemediationsProps> = ({ | ||
| remediations, | ||
| productNameMap, | ||
| }) => { | ||
| const grouped = React.useMemo( | ||
| () => groupByCategory(remediations), | ||
| [remediations], | ||
| ); | ||
|
|
||
| return ( | ||
| <ExpandableSection toggleText="Remediations"> | ||
| <Flex direction={{ default: "column" }} gap={{ default: "gapMd" }}> | ||
| {Array.from(grouped.entries()).map(([category, rems]) => ( | ||
| <FlexItem key={category}> | ||
| <Card isPlain> | ||
| <CardTitle> | ||
| <Label isCompact>{category.replace(/_/g, " ")}</Label> ( | ||
| {rems.length}) | ||
| </CardTitle> | ||
| <CardBody> | ||
| <Flex | ||
| direction={{ default: "column" }} | ||
| gap={{ default: "gapSm" }} | ||
| > | ||
| {rems.map((rem, i) => ( | ||
| <FlexItem key={`${category}-${i}`}> | ||
| <RemediationCard | ||
| remediation={rem} | ||
| productNameMap={productNameMap} | ||
| /> | ||
| </FlexItem> | ||
| ))} | ||
| </Flex> | ||
| </CardBody> | ||
| </Card> | ||
| </FlexItem> | ||
| ))} | ||
| </Flex> | ||
| </ExpandableSection> | ||
| ); | ||
| }; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.