chore(eslint): enable @typescript-eslint/no-unused-expressions rule

[carlosthe19916]

Summary

• Remove the @typescript-eslint/no-unused-expressions override from ESLint config
• Replace short-circuit expressions used as statements (cond && fn()) with explicit if statements

Test plan

• npm run lint passes with 0 warnings

🤖 Generated with Claude Code

Summary by Sourcery

Enable the @typescript-eslint/no-unused-expressions ESLint rule and update code to comply with it.

Enhancements:

• Replace short-circuit expression statements with explicit conditional logic in client, server, and test utilities to satisfy no-unused-expressions linting.

Chores:

• Remove the ESLint override that disabled @typescript-eslint/no-unused-expressions.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Enables the @typescript-eslint/no-unused-expressions ESLint rule by removing its override and refactors all affected short-circuit expression statements into explicit, rule-compliant conditionals across client, server, e2e, and logging code.

Flow diagram for conditional side effects after enabling no_unused_expressions

flowchart TD
  A[Click DownloadAndLeave button] --> B[handleDownloadCSV]
  B --> C{blocker.state === blocked}
  C -->|true| D[blocker.proceed]
  C -->|false| E[Do nothing]

  subgraph Cancel_action
    A2[Click Cancel button] --> C2{blocker.state === blocked}
    C2 -->|true| D2[blocker.reset]
    C2 -->|false| E2[Do nothing]
  end

Loading

File-Level Changes

Change	Details	Files
Refactor short-circuit control-flow expressions into explicit conditionals to satisfy no-unused-expressions.	Replace ternary-style IIFE error throw with a straightforward if (!sorted) throw in ToolbarTable sorting validation Change logger methods to use explicit if checks before console logging based on CURRENT_LOG_LEVEL Update various React event handlers to replace pattern cond && action() with if (cond) action() in navigation blocking, drilldown selection, toolbar expansion, menu open/close, and focus management logic Use an explicit if (debugMode) guard before console.log in the server entrypoint	e2e/tests/ui/helpers/ToolbarTable.ts e2e/tests/common/constants.ts client/src/app/pages/sbom-scan/sbom-scan.tsx client/src/app/components/DrilldownSelect/DrilldownSelect.tsx client/src/app/components/ToolbarBulkExpander.tsx client/src/app/pages/home/components/WatchedSbom.tsx client/src/app/pages/search/components/SearchMenu.tsx server/src/index.ts
Tighten ESLint configuration by enabling @typescript-eslint/no-unused-expressions.	Remove the override that disabled @typescript-eslint/no-unused-expressions so the rule now applies project-wide	eslint.config.mjs

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codecov]

Codecov Report

❌ Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.70%. Comparing base (16a6bec) to head (cbc5aad).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...app/components/DrilldownSelect/DrilldownSelect.tsx	0.00%	1 Missing ⚠️
client/src/app/components/ToolbarBulkExpander.tsx	0.00%	1 Missing ⚠️
...ient/src/app/pages/home/components/WatchedSbom.tsx	0.00%	1 Missing ⚠️
...ent/src/app/pages/search/components/SearchMenu.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1057      +/-   ##
==========================================
+ Coverage   50.68%   50.70%   +0.01%     
==========================================
  Files         253      253              
  Lines        5499     5499              
  Branches     1660     1660              
==========================================
+ Hits         2787     2788       +1     
  Misses       2440     2440              
+ Partials      272      271       -1     

Flag	Coverage Δ
e2e	68.96% <50.00%> (+0.02%)	⬆️
unit	2.01% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.