Skip to content

chore(eslint): enable @eslint-react/no-create-ref rule#1056

Draft
carlosthe19916 wants to merge 4 commits into
guacsec:mainfrom
carlosthe19916:hotfix/enable-no-create-ref
Draft

chore(eslint): enable @eslint-react/no-create-ref rule#1056
carlosthe19916 wants to merge 4 commits into
guacsec:mainfrom
carlosthe19916:hotfix/enable-no-create-ref

Conversation

@carlosthe19916
Copy link
Copy Markdown
Collaborator

@carlosthe19916 carlosthe19916 commented May 27, 2026

Summary

  • Remove the @eslint-react/no-create-ref override from ESLint config
  • Replace React.createRef() with React.useRef(null) in all function components
  • createRef() creates a new ref on every render; useRef() persists across renders

Test plan

  • npm run lint passes with 0 warnings

🤖 Generated with Claude Code

Summary by Sourcery

Enable the @eslint-react/no-create-ref lint rule and update React components to use useRef-based refs instead of createRef in function components.

Enhancements:

  • Replace React.createRef usages with React.useRef(null) in function components for tab and popover element references.

Build:

  • Tighten ESLint configuration by removing the override that disabled the @eslint-react/no-create-ref rule.

Replace React.createRef() with React.useRef(null) in all function
components. createRef() creates a new ref on every render; useRef()
persists across renders.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented May 27, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Enables the @eslint-react/no-create-ref rule by removing its override and updating React function components to use useRef() instead of createRef(), ensuring refs persist across renders and comply with the new linting constraint.

Sequence diagram for ref handling change in React function components

sequenceDiagram
  actor User
  participant FunctionComponent as FunctionComponent
  participant React
  participant DomElement as DomElement

  rect rgb(235,235,235)
    Note over FunctionComponent,React: Before - using React.createRef()
    User->>FunctionComponent: render()
    FunctionComponent->>React: createRef()
    React-->>FunctionComponent: Ref_instance_A
    FunctionComponent->>DomElement: attach Ref_instance_A

    User->>FunctionComponent: re-render()
    FunctionComponent->>React: createRef()
    React-->>FunctionComponent: Ref_instance_B
    FunctionComponent->>DomElement: attach Ref_instance_B (new ref each render)
  end

  rect rgb(220,245,220)
    Note over FunctionComponent,React: After - using React.useRef(null)
    User->>FunctionComponent: render()
    FunctionComponent->>React: useRef(null)
    React-->>FunctionComponent: Ref_instance_persistent
    FunctionComponent->>DomElement: attach Ref_instance_persistent

    User->>FunctionComponent: re-render()
    FunctionComponent->>React: useRef(null)
    React-->>FunctionComponent: Ref_instance_persistent (same ref)
    FunctionComponent->>DomElement: keep Ref_instance_persistent
  end
Loading

File-Level Changes

Change Details Files
Replace React.createRef() with React.useRef(null) in function components so refs persist across renders and satisfy the lint rule.
  • Update tab refs in SBOM details page to use React.useRef with HTMLElement
null
  • Update popover/tab refs in search tabs component to use React.useRef with HTMLElement
  • Tighten ESLint configuration by enabling the @eslint-react/no-create-ref rule.
    • Remove the explicit override that disabled @eslint-react/no-create-ref in the ESLint config
    eslint.config.mjs

    Tips and commands

    Interacting with Sourcery

    • Trigger a new review: Comment @sourcery-ai review on the pull request.
    • Continue discussions: Reply directly to Sourcery's review comments.
    • Generate a GitHub issue from a review comment: Ask Sourcery to create an
      issue from a review comment by replying to it. You can also reply to a
      review comment with @sourcery-ai issue to create an issue from it.
    • Generate a pull request title: Write @sourcery-ai anywhere in the pull
      request title to generate a title at any time. You can also comment
      @sourcery-ai title on the pull request to (re-)generate the title at any time.
    • Generate a pull request summary: Write @sourcery-ai summary anywhere in
      the pull request body to generate a PR summary at any time exactly where you
      want it. You can also comment @sourcery-ai summary on the pull request to
      (re-)generate the summary at any time.
    • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
      request to (re-)generate the reviewer's guide at any time.
    • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
      pull request to resolve all Sourcery comments. Useful if you've already
      addressed all the comments and don't want to see them anymore.
    • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
      request to dismiss all existing Sourcery reviews. Especially useful if you
      want to start fresh with a new review - don't forget to comment
      @sourcery-ai review to trigger a new review!

    Customizing Your Experience

    Access your dashboard to:

    • Enable or disable review features such as the Sourcery-generated pull request
      summary, the reviewer's guide, and others.
    • Change the review language.
    • Add, remove or edit custom review instructions.
    • Adjust other review settings.

    Getting Help

    Copy link
    Copy Markdown
    Contributor

    @sourcery-ai sourcery-ai Bot left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Hey - I've reviewed your changes and they look great!


    Sourcery is free for open source - if you like our reviews please consider sharing them ✨
    Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

    @codecov
    Copy link
    Copy Markdown

    codecov Bot commented May 27, 2026

    Codecov Report

    ✅ All modified and coverable lines are covered by tests.
    ✅ Project coverage is 50.66%. Comparing base (16a6bec) to head (881fa45).

    Additional details and impacted files
    @@            Coverage Diff             @@
    ##             main    #1056      +/-   ##
    ==========================================
    - Coverage   50.68%   50.66%   -0.02%     
    ==========================================
      Files         253      253              
      Lines        5499     5499              
      Branches     1660     1660              
    ==========================================
    - Hits         2787     2786       -1     
    - Misses       2440     2441       +1     
      Partials      272      272              
    Flag Coverage Δ
    e2e 68.91% <100.00%> (-0.03%) ⬇️
    unit 2.01% <0.00%> (ø)

    Flags with carried forward coverage won't be shown. Click here to find out more.

    ☔ View full report in Codecov by Sentry.
    📢 Have feedback on the report? Share it here.

    🚀 New features to boost your workflow:
    • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
    • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

    @carlosthe19916 carlosthe19916 marked this pull request as draft May 27, 2026 12:14
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    Status: No status

    Development

    Successfully merging this pull request may close these issues.

    1 participant