chore(eslint): enable @eslint-react/no-create-ref rule#1056
Draft
carlosthe19916 wants to merge 4 commits into
Draft
chore(eslint): enable @eslint-react/no-create-ref rule#1056carlosthe19916 wants to merge 4 commits into
carlosthe19916 wants to merge 4 commits into
Conversation
Replace React.createRef() with React.useRef(null) in all function components. createRef() creates a new ref on every render; useRef() persists across renders. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideEnables the @eslint-react/no-create-ref rule by removing its override and updating React function components to use useRef() instead of createRef(), ensuring refs persist across renders and comply with the new linting constraint. Sequence diagram for ref handling change in React function componentssequenceDiagram
actor User
participant FunctionComponent as FunctionComponent
participant React
participant DomElement as DomElement
rect rgb(235,235,235)
Note over FunctionComponent,React: Before - using React.createRef()
User->>FunctionComponent: render()
FunctionComponent->>React: createRef()
React-->>FunctionComponent: Ref_instance_A
FunctionComponent->>DomElement: attach Ref_instance_A
User->>FunctionComponent: re-render()
FunctionComponent->>React: createRef()
React-->>FunctionComponent: Ref_instance_B
FunctionComponent->>DomElement: attach Ref_instance_B (new ref each render)
end
rect rgb(220,245,220)
Note over FunctionComponent,React: After - using React.useRef(null)
User->>FunctionComponent: render()
FunctionComponent->>React: useRef(null)
React-->>FunctionComponent: Ref_instance_persistent
FunctionComponent->>DomElement: attach Ref_instance_persistent
User->>FunctionComponent: re-render()
FunctionComponent->>React: useRef(null)
React-->>FunctionComponent: Ref_instance_persistent (same ref)
FunctionComponent->>DomElement: keep Ref_instance_persistent
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1056 +/- ##
==========================================
- Coverage 50.68% 50.66% -0.02%
==========================================
Files 253 253
Lines 5499 5499
Branches 1660 1660
==========================================
- Hits 2787 2786 -1
- Misses 2440 2441 +1
Partials 272 272
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@eslint-react/no-create-refoverride from ESLint configReact.createRef()withReact.useRef(null)in all function componentscreateRef()creates a new ref on every render;useRef()persists across rendersTest plan
npm run lintpasses with 0 warnings🤖 Generated with Claude Code
Summary by Sourcery
Enable the @eslint-react/no-create-ref lint rule and update React components to use useRef-based refs instead of createRef in function components.
Enhancements:
Build: