chore(eslint): enable @eslint-react/jsx-no-key-after-spread rule

[carlosthe19916]

Summary

• Remove the @eslint-react/jsx-no-key-after-spread override from ESLint config
• Move key prop before spread props in SelectOption components to avoid deoptimization with the automatic JSX runtime

Test plan

• npm run lint passes with 0 warnings

🤖 Generated with Claude Code

Summary by Sourcery

Enable the eslint rule preventing JSX keys after spread props and update affected select option components accordingly.

Enhancements:

• Reorder key and spread props in select option components to comply with JSX key-after-spread linting and avoid automatic runtime deoptimizations.

Build:

• Remove the override disabling @eslint-react/jsx-no-key-after-spread in the ESLint configuration to enforce the rule project-wide.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Enables the @eslint-react/jsx-no-key-after-spread lint rule by removing its override and updating SelectOption JSX usage so that the key prop appears before any spread props, avoiding automatic JSX runtime deoptimizations.

Flow diagram for enabling jsx-no-key-after-spread lint rule

flowchart LR
  ESLintConfig[ESLint config]
  RuleOverrideNode["@eslint-react/jsx-no-key-after-spread override"]
  LintRun[npm run lint]
  MultiselectFilterControl[MultiselectFilterControl SelectOption]
  SelectFilterControl[SelectFilterControl SelectOption]

  ESLintConfig -->|removes RuleOverride| RuleOverrideNode
  ESLintConfig --> LintRun
  LintRun -->|checks key before spread| MultiselectFilterControl
  LintRun -->|checks key before spread| SelectFilterControl

Loading

File-Level Changes

Change	Details	Files
Reorder key and spread props in SelectOption usage in multiselect filter to satisfy jsx-no-key-after-spread.	Move key={value} before optionProps spread in SelectOption JSX. Keep conditional hasCheckbox spread after optionProps and key while preserving existing option behavior. Ensure focusedItemIndex-dependent props and IDs remain unchanged.	client/src/app/components/FilterToolbar/MultiselectFilterControl.tsx
Reorder key and spread props in SelectOption usage in single select filter to satisfy jsx-no-key-after-spread.	Move key={value} before optionProps spread in SelectOption JSX. Preserve isSelected logic based on filterValue while only changing prop order.	client/src/app/components/FilterToolbar/SelectFilterControl.tsx
Enable @eslint-react/jsx-no-key-after-spread linting by removing explicit rule disablement.	Delete the @eslint-react/jsx-no-key-after-spread: "off" override from the ESLint flat config. Allow the rule to use its default severity configured elsewhere or by the plugin.	eslint.config.mjs

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.68%. Comparing base (16a6bec) to head (e6f4655).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1052   +/-   ##
=======================================
  Coverage   50.68%   50.68%           
=======================================
  Files         253      253           
  Lines        5499     5499           
  Branches     1660     1660           
=======================================
  Hits         2787     2787           
- Misses       2440     2441    +1     
+ Partials      272      271    -1     

Flag	Coverage Δ
e2e	68.93% <ø> (ø)
unit	2.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.