chore(eslint): enable @eslint-react/purity rule#1051
Draft
carlosthe19916 wants to merge 4 commits into
Draft
Conversation
Move impure calls out of render:
- Replace document.createElement("span") with useRef(null) in PageDrawerContext
- Extract new Date().getFullYear() to module-level constant in about.tsx
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideEnables the @eslint-react/purity rule by removing its override, and updates React components to avoid impure render-time side effects by using a ref initialized to null and hoisting a Date computation to module scope. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Now that
drawerFocusRefis initialized withnullinstead of an actualspanelement, double-check all usages to ensure they handle the potentially nullcurrentvalue (e.g., optional chaining or early returns before calling.focus()or similar). - If the
AboutAppcomponent can stay mounted across a year boundary (e.g., long-lived admin consoles), consider computing the year at render-time or when needed instead of at module-load, so the displayed copyright year stays accurate without a full reload.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Now that `drawerFocusRef` is initialized with `null` instead of an actual `span` element, double-check all usages to ensure they handle the potentially null `current` value (e.g., optional chaining or early returns before calling `.focus()` or similar).
- If the `AboutApp` component can stay mounted across a year boundary (e.g., long-lived admin consoles), consider computing the year at render-time or when needed instead of at module-load, so the displayed copyright year stays accurate without a full reload.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1051 +/- ##
=======================================
Coverage 50.68% 50.69%
=======================================
Files 253 253
Lines 5499 5500 +1
Branches 1660 1660
=======================================
+ Hits 2787 2788 +1
- Misses 2440 2441 +1
+ Partials 272 271 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@eslint-react/purityoverride from ESLint configdocument.createElement("span")withuseRef(null)inPageDrawerContextnew Date().getFullYear()to module-level constant inabout.tsxTest plan
npm run lintpasses with 0 warnings🤖 Generated with Claude Code
Summary by Sourcery
Enable the @eslint-react/purity rule and adjust React components to comply with purity constraints.
Enhancements:
Build: