chore(eslint): enable @eslint-react/static-components rule#1050
Draft
carlosthe19916 wants to merge 5 commits into
Draft
chore(eslint): enable @eslint-react/static-components rule#1050carlosthe19916 wants to merge 5 commits into
carlosthe19916 wants to merge 5 commits into
Conversation
Move presets object and IconWithOptionalTooltip component outside the IconedStatus render function to avoid re-creation on each render. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Reviewer's GuideEnables the @eslint-react/static-components rule by refactoring IconedStatus so its presets map and tooltip wrapper are defined as top-level static components instead of being recreated on each render, and by removing the rule override from the ESLint config. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
IconWithOptionalTooltip, consider widening thechildrentype fromReact.ReactElementtoReact.ReactNode(or at leastReact.ReactElement | React.ReactNode) so the wrapper can be used with fragments or text nodes without additional casting.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `IconWithOptionalTooltip`, consider widening the `children` type from `React.ReactElement` to `React.ReactNode` (or at least `React.ReactElement | React.ReactNode`) so the wrapper can be used with fragments or text nodes without additional casting.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Move LogButton to module level and pass messages, setLogData, toggleLogModal as explicit props. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1050 +/- ##
=======================================
Coverage 50.68% 50.68%
=======================================
Files 253 253
Lines 5499 5499
Branches 1660 1660
=======================================
Hits 2787 2787
Misses 2440 2440
Partials 272 272
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@eslint-react/static-componentsoverride from ESLint configpresetsobject andIconWithOptionalTooltipcomponent outside ofIconedStatusrender to avoid re-creation on each renderTest plan
npm run lintpasses with 0 warnings🤖 Generated with Claude Code
Summary by Sourcery
Enable stricter React ESLint rules and refactor IconedStatus to use static configuration and components.
Enhancements:
Build: