chore(eslint): enable no-var and preserve-caught-error rules

[carlosthe19916]

Summary

• Remove no-var and preserve-caught-error from the ESLint "off" overrides so default strictness applies
• Fix var → const in e2e API tests
• Attach cause to re-thrown error in e2e UI helper

Test plan

• npm run lint passes with 0 warnings

🤖 Generated with Claude Code

Summary by Sourcery

Tighten ESLint configuration by enforcing modern error handling and variable declaration rules in e2e code.

Enhancements:

• Replace var with const in e2e API tests and helpers to comply with stricter linting rules.
• Attach the original error as a cause when rethrowing download verification failures in the e2e UI helper.
• Remove overrides that disabled the no-var and preserve-caught-error ESLint rules so default strictness applies.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Enables stricter ESLint behavior by removing overrides that disabled no-var and preserve-caught-error, then updates affected e2e tests/helpers to use const instead of var and to preserve the original error as a cause when rethrowing.

Flow diagram for updated error rethrowing with cause in UI helper

flowchart TD
  A[Run UI download verification helper] --> B[Download verification fails]
  B --> C[catch err]
  C --> D[Create new Error with message and cause: err]
  D --> E[throw new Error]
  E --> F[Caller receives error with preserved original cause]

Loading

File-Level Changes

Change	Details	Files
Enable stricter ESLint rules by removing overrides for no-var and preserve-caught-error.	Remove no-var rule from the list of explicit overrides set to off so the default rule configuration applies. Remove preserve-caught-error rule from the list of explicit overrides set to off so the default rule configuration applies.	eslint.config.mjs
Update e2e API tests and helpers to satisfy the no-var rule by using const for local variables and arrays.	Replace var with const for URL-encoded purl, alias, and CPE values in analysis alias API tests. Replace var with const when building full SBOM paths in the general e2e API helpers.	e2e/tests/api/features/analysis-alias.ts e2e/tests/api/helpers/general-helpers.ts
Preserve the original error when rethrowing download verification failures in the UI helper to comply with preserve-caught-error and improve diagnostics.	Wrap the caught error as the cause when creating a new Error in verifyDownload so the original error is preserved and visible in error chains.	e2e/tests/ui/pages/Helpers.ts

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.70%. Comparing base (16a6bec) to head (922d4f3).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1048      +/-   ##
==========================================
+ Coverage   50.68%   50.70%   +0.01%     
==========================================
  Files         253      253              
  Lines        5499     5499              
  Branches     1660     1660              
==========================================
+ Hits         2787     2788       +1     
  Misses       2440     2440              
+ Partials      272      271       -1     

Flag	Coverage Δ
e2e	68.96% <ø> (+0.02%)	⬆️
unit	2.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sourcery-ai]

Hey - I've left some high level feedback:

• In getFullSbomPaths, consider using return sbomPaths.map(path => ${sbomDir}/${path}); instead of mutating an array with forEach to make the helper more concise and idiomatic.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `getFullSbomPaths`, consider using `return sbomPaths.map(path => `${sbomDir}/${path}`);` instead of mutating an array with `forEach` to make the helper more concise and idiomatic.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}