Skip to content

chore: remove Coverage from Merge Queue#1044

Open
carlosthe19916 wants to merge 3 commits into
guacsec:mainfrom
carlosthe19916:hotfix/merge-group
Open

chore: remove Coverage from Merge Queue#1044
carlosthe19916 wants to merge 3 commits into
guacsec:mainfrom
carlosthe19916:hotfix/merge-group

Conversation

@carlosthe19916
Copy link
Copy Markdown
Collaborator

@carlosthe19916 carlosthe19916 commented May 21, 2026

There is no need to run the ci-coverage in the Merge Group. the ci-coverage is useful in

  • PRs: so we measure the test coverage change
  • main commits: so we send the current test coverage

but having it in the merge queue does not add any value

Summary by Sourcery

CI:

  • Stop triggering the ci-coverage GitHub Actions workflow for merge_group events.

Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented May 21, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removes the merge_group trigger from the ci-coverage GitHub Actions workflow so coverage no longer runs for merge queue groups, only on PRs and main branch pushes or workflow calls.

Flow diagram for updated ci-coverage GitHub Actions triggers

flowchart LR
    A[Pull request events
    pull_request] --> D[Run ci-coverage]
    B[Push to main
    push] --> D
    C[workflow_call
    from other workflows] --> D

    %% Previously:
    %% E[Merge group events
    %% merge_group] --> D
    %% E is now removed, so merge group no longer triggers ci-coverage
Loading

File-Level Changes

Change Details Files
Stop running ci-coverage workflow for merge queue (merge_group) events.
  • Removed merge_group from the list of workflow triggers in the ci-coverage GitHub Actions workflow
  • Kept push to main and workflow_call triggers intact for ci-coverage execution
.github/workflows/ci-coverage.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.66%. Comparing base (16a6bec) to head (3456cae).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1044      +/-   ##
==========================================
- Coverage   50.68%   50.66%   -0.02%     
==========================================
  Files         253      253              
  Lines        5499     5499              
  Branches     1660     1660              
==========================================
- Hits         2787     2786       -1     
- Misses       2440     2441       +1     
  Partials      272      272              
Flag Coverage Δ
e2e 68.91% <ø> (-0.03%) ⬇️
unit 2.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant