Populate the subject line with the item/page title when sharing by email#122
Closed
mikej wants to merge 2 commits intogrp:masterfrom
Closed
Populate the subject line with the item/page title when sharing by email#122mikej wants to merge 2 commits intogrp:masterfrom
mikej wants to merge 2 commits intogrp:masterfrom
Conversation
|
Yes, agree, this would be very helpful. |
Author
|
Hi Grant Thanks for looking at my pull request so quickly. Sorry, I hadn't spotted that this was undocumented. I was going off the example in this Stack Overflow answer. I've just done a bit more digging and it looks like activityViewController:subjectForActivityType: is the official way to do this on iOS 7.0 and later so I will take a look and redoing this change using that approach. |
Owner
|
Cool, that sounds like a good solution. |
Author
|
Hi. When you get a chance, please take a look at this updated version that uses |
Author
|
PR is from a long time ago and app hasn't been updated recently so closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
Please can you consider incorporating this, or something like it, into a future release. It's handy to have the subject pre-populated when sharing links with people and is also useful when using share via email to add to services like Pinboard etc. I did see there was an earlier pull request about something similar, but I think that one was adding to the message body rather than the subject.
Screenshot as an example of what this looks like in the message composer: