Repository navigation
fix(minestom): combine module icons in the native nameplate row - #64
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Voice currently creates a separate TextDisplay above each native nameplate. Expose a shared
NameplateStatusesservice so modules can contribute viewer-specific icons to the existing native below-name row. Permissions appends its network-wide Bedrock indicator once and retains ownership handling for gameplay scoreboards.Provider handles unregister on module shutdown; one failed provider cannot stop nameplate updates. The native row also works when voice/party is the only status and no Bedrock players are present.
Validation: full
./gradlew test spotlessCheckpassed, including provider lifecycle, exception isolation, shared voice/Bedrock rows, Java/Bedrock fonts and gameplay-objective regressions. Voice integration is validated separately before deployment.