Repository navigation
fix(minestom): use gray player names and a native status row - #61
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Player names above the head now use Minecraft gray (§7), while rank badges retain their colors. Bedrock status moves into the native below-name row without adding entities; the tab list keeps its inline icon and Simple Voice Chat remains client-controlled.
The status row uses viewer-specific Java/Bedrock glyphs, sends only changed scores, and yields to gameplay objectives. It resumes after those objectives are cleared or deleted, including when socket packet delivery is delayed.
Forward the configured package credential into the reusable Docker workflow so image builds can resolve the private Maven dependencies.
Validation:
./gradlew test spotlessCheckpassed. Tests cover status updates, cleanup, edition changes, concurrent gameplay objectives, and network-wide edition rosters from multiple proxies. No live visual client verification yet.