Repository navigation
fix(drain): retry bounded handoffs before the shutdown deadline - #103
Merged
Merged
Conversation
|
This was referenced Oct 31, 2026
Merged
lusu007
marked this pull request as ready for review
October 31, 2026 19:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When several proxies drain together, a temporary shared handoff-budget refusal should leave the player at the source and retry within the remaining drain window. Add a deduplicated queue with bounded work per tick and keep round protection and deadline disconnect behavior.
Remove the bare-transfer fallback when plugin-player is missing, and suppress repeat sends while a drain transfer is staged or already sent. Tickets are issued at the actual send attempt.
Validation: spotless and complete plugin-agones suite, including budget retry, queue deduplication, no-spin, departed/round players and missing-handoff coverage. The existing restart and round tests remain green.
The updated plugin must be baked into the Velocity image for the corresponding rollout. No public ingress or live activation is changed here.
Review regression: persistently refused entries rotate to the tail so supported players cannot starve. Complete suite: 129 tests.
Related changes: service-player#152, plugin-player#79, plugin-agones#103, plugin-proxy#116, containers#335.