Skip to content

fix: wait for deployment terminal status - #51

Merged
lusu007 merged 2 commits into
mainfrom
feat/managed-push-replacement
Aug 3, 2026
Merged

lusu007 merged 2 commits into
mainfrom
feat/managed-push-replacement

Conversation

@lusu007

@lusu007 lusu007 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Pull Request

Description

Keeps grounds push attached through deployment completion instead of treating build_succeeded as the terminal result. The command now reports deployment readiness or deployment failure.

Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 💥 Breaking change
  • ♻️ Refactoring
  • 📚 Documentation
  • 🔧 Chore

Related Issues

  • N/A

Testing

  • Unit tests pass (./gradlew :plugin:test --rerun-tasks)
  • Manual testing completed (requires deployed Forge API)
  • New tests added for new functionality

Checklist

  • I have performed a self-review of my own code
  • Tests have been added/updated and pass (if needed)
  • Documentation has been updated (if needed)

@lusu007
lusu007 marked this pull request as ready for review August 3, 2026 13:25

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b6983bb004

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugin/src/main/kotlin/gg/grounds/push/tasks/GroundsPushTask.kt Outdated
@lusu007
lusu007 merged commit b2955f8 into main Aug 3, 2026
1 check passed
@lusu007
lusu007 deleted the feat/managed-push-replacement branch August 3, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant