Repository navigation
feat: forward the agones and matchmaking blocks to forge - #47
Merged
Merged
Conversation
The upload manifest is hand-built field by field, so a block nobody named there simply does not exist as far as forge is concerned. `agones:` and `matchmaking:` were both being dropped in silence. `agones.replicas` never mattered — forge defaults it to 1, which is what everyone wanted anyway. `matchmaking:` matters enormously: it is what makes forge render GROUNDS_MATCHMAKING onto the pod and DECLARE the Agones `matches` counter on the Fleet. Without the counter declared, the matchmaker's allocation selector matches nothing, every allocation comes back UnAllocated, and no match can ever be placed — on a fleet that is sitting there Ready. Verified live: the pushed `duel` fleet came up Ready with no counters and no GROUNDS_MATCHMAKING, and the block was right there in its grounds.yaml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upload manifest is hand-built field by field, so a block nobody named there simply does not exist as far as forge is concerned.
agones:andmatchmaking:were both being dropped in silence.agones.replicasnever mattered — forge defaults it to 1, which is what everyone wanted anyway. That is exactly why nobody noticed.matchmaking:matters enormously. It is what makes forge renderGROUNDS_MATCHMAKINGonto the pod and declare the Agonesmatchescounter on the Fleet. Without the counter declared, the matchmaker's allocation selector matches nothing, every allocation comes backUnAllocated, and no match can ever be placed — on a fleet that is sitting thereReady, looking perfectly healthy.Verified live
The pushed
duelfleet invcluster-dahendriikcame up Ready with:…and the
matchmaking: { matchesPerServer: 4 }block was right there in itsgrounds.yaml, being thrown away by this file.(It also explains why the server readied itself at all: with no
GROUNDS_MATCHMAKING, plugin-agones stays in self-managed mode.)