test(comment-review): promptfoo eval suite + root eval tooling#4
Merged
Conversation
Single shared root node_modules + scripts to run every plugin's eval suite. - package.json: devDeps (@anthropic-ai/claude-agent-sdk, promptfoo) + eval scripts - scripts/run-evals.sh: discovers and runs plugins/*/evals/promptfooconfig.yaml - pnpm-workspace.yaml: allowBuilds=false (avoids ERR_PNPM_IGNORED_BUILDS on pnpm 11) - .gitignore: node_modules, pnpm-lock.yaml, eval outputs
5 evals (R1-R12 comment-quality verdicts) running the real skill via the native anthropic:claude-agent-sdk provider (local plugin, subscription auth). - fixtures: 2 ported from skill-creator + 4 reconstructed (datadog, scheduler, dlq pair) - assertions: llm-rubric per criterion + regex 'skill ran' proxy - baseline: sonnet 41/42, opus 42/42; eval-3 §4.1 accepts REWRITE-or-REMOVE, eval-4 token-verification kept strict as a model-capability marker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Turns the leftover skill-creator eval artifacts for the comment-review skill into a repeatable promptfoo eval suite, plus shared root-level tooling to run evals across the repo.
How the suite works
anthropic:claude-agent-sdk, loadingcomment-reviewas a local plugin and running the real skill with tools — on the Claude Code subscription (apiKeyRequired: false, noANTHROPIC_API_KEYneeded).eval_metadata.json/evals.jsonbullets asllm-rubric, plus aregex"skill ran" proxy (plugin skills load via Agent-Skills injection, soskill-used/skillCallsstay empty).payment-validator.ts,host-allowlist.ts) + 4 reconstructed from their assertion lists (datadog-integration.tf,scheduler.ts,dlq-codes.ts+dlq.handler.ts).Baseline
Two assertions are deliberately instructive:
§4.1— genuine judgment boundary (after the spec-id is stripped the comment borders on R1). Accepts REWRITE or REMOVE; only "kept as-is" fails.Root tooling
package.json— single sharednode_modules, dev deps + eval scripts.scripts/run-evals.sh— discovers and runs everyplugins/*/evals/promptfooconfig.yaml.pnpm-workspace.yaml—allowBuilds: false(avoidsERR_PNPM_IGNORED_BUILDSbreaking pnpm 11's pre-run check).Run
See
plugins/comment-review/evals/README.mdfor details and knobs.