Skip to content

Add browser_type / executable_path to MarkdownifyWebScraperDriver#2230

Draft
feder-cr wants to merge 1 commit into
griptape-ai:mainfrom
feder-cr:add-markdownify-browser-type
Draft

Add browser_type / executable_path to MarkdownifyWebScraperDriver#2230
feder-cr wants to merge 1 commit into
griptape-ai:mainfrom
feder-cr:add-markdownify-browser-type

Conversation

@feder-cr

@feder-cr feder-cr commented Jul 2, 2026

Copy link
Copy Markdown

fetch_url was hardcoded to p.chromium.launch(headless=True), so there was no way to point it at a different engine or a custom binary. Adds browser_type (defaults to 'chromium', unchanged behavior) and executable_path fields, following the attrs field pattern already used here. Motivated by invisible_playwright, a Playwright wrapper around a Firefox build patched at the source level for a realistic fingerprint, useful for scrapes that hit bot detection on the default Chromium path. Opened as draft, happy to adjust naming or add a test.

@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...vers/web_scraper/markdownify_web_scraper_driver.py 66.66% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@collindutter collindutter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you please add some unit tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants