feat: ensure ffi converts to markdown#7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert FFI to Return Markdown Instead of HTML
This PR updates the
ConvertFFI function to return Markdown output instead of cleaned HTML, making the library more useful for consuming applications that need Markdown format.Motivation
The previous implementation returned sanitized HTML after stripping specified elements. However, most consuming applications (Python, Node.js, etc.) likely need Markdown format rather than HTML for display, storage, or further processing. By converting to Markdown in the FFI layer, we provide more useful output and leverage the existing
HTMLToMarkdownconverter functionality.Changes
Convertfunction incmd/libschema/main.goto callconverter.HTMLToMarkdown()on the processed HTML before returning//exportdirective placement - moved it immediately before the function declaration (required for proper CGO export)'This content should remain') instead of HTML tags ('<main>')Features
Usage
The function signature remains unchanged - consuming applications don't need code modifications. However, the returned string is now Markdown format:
Applications expecting HTML output should be updated to handle Markdown, or a separate HTML-returning function should be added if both formats are needed.