Fix NABC inter-syllable overflow spacing and add nabcintersyllablemingap - #1716
Fix NABC inter-syllable overflow spacing and add nabcintersyllablemingap#1716lbssousa wants to merge 1 commit into
Conversation
|
In #1720 I'm working on moving everything related to syllablefinalskip into Lua, while this PR adds a dependency on syllablefinalskip. So merging this PR first would create some extra work needed on #1720. On the other hand, if #1720 were merged first, then managing the space between NABC syllables would become much easier. It would just involve adding a pass to the Lua Maybe #1720 can reach a point where it's mergable in a few days. @lbssousa, what do you think about trying this in Lua instead? |
|
Sure, @davidweichiang . I'll try it when your work is ready. We can hold this PR for now. |
gregorio-project#1715) Replace the per-syllable NABC extrakern mechanism, which widened the notes box whenever NABC extended past it (even when the natural inter-syllable spacing was already sufficient), with a minimum-distance constraint in the Lua syllable-spacing filter introduced by gregorio-project#1720. The filter now records the zero-width NABC voice boxes (part=7/8) while scanning syllables and, for each NABC voice present in two consecutive syllables, widens the syllablefinalskip just enough to keep at least nabcintersyllablemingap between the end of one syllable's neumes and the start of the next. Distances are measured on the actual node list, per voice, so no space is added when the neumes already fit. The new nabcintersyllablemingap distance (default 0.06 cm, 25% of intersyllablespacenotes) is configurable via \grechangedim and scales with the score factor.
|
@davidweichiang Just refactored here PR after #1720 is merged, but I also depend on PR #1764 do be merged in order to complete this one. |
|
What do you need from #1764? Maybe we can cherry-pick those into a separate smaller PR. |
|
Essentially, I need the implementation around |
Fixes #1715.