feat: expand Pretext layouts and fix quote/mini-tile composition - #45
Merged
Conversation
Apply pretext_slot across comparison, funnel, grid, insight story, slide cards, and timeline. Open hero gains insight callout Pretext, shared width constants, and callout CSS for icon stacking and slot width. pretext_utils: parse italic/oblique/bold and numeric font-weight for valid SVG font attributes; clip inner SVG safely. Story mini-tile: taller foreignObject bands when Pretext so multi-line text is not clipped; optional legacy layout for demos. Add refinement demo script and smoke tests; wire tests into Makefile. Document Pretext vs freeform wireframe and foreignObject in SVG_COMPOSITION; README acknowledgments; gitignore docs/plans for local notes. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expands Pretext rendering across multiple diagrams and fixes the overlapping quote/mini-tile composition issues.
Key changes
Testing
docker run --rm --ipc=host --init -v /Users/grmeyer/playground/writing/utils/modern-graphics:/app -w /app --entrypoint /bin/bash modern-graphics -c "pip install pytest -q && pytest -q tests/smoke/test_overhaul_phase1_smoke.py tests/smoke/test_layout_strategy_smoke.py tests/smoke/test_create_cli_phase3_smoke.py tests/smoke/test_create_story_regression_phase7_smoke.py tests/smoke/test_story_tile_pretext_smoke.py tests/smoke/test_export_phase4_smoke.py tests/smoke/test_cli_migration_phase5_smoke.py tests/smoke/test_export_presets_phase6_smoke.py"
.................... [100%]
20 passed in 0.18s (smoke suite)
Made with Cursor