Follow-up fixes: dead code, compose env vars, POST /verify, dep cleanup, replay visibility - #2
Merged
Merged
Conversation
… replay visibility - Remove unreachable default-secret warning in index.ts (32-char minimum already rejects it) - Forward EXPIREMINUTES, MAXRECORDS, PORT in compose.yaml - Add POST /verify endpoint accepting JSON body; keep GET for backward compatibility - Update demo proxy POST /test to use POST /verify (removes token from logs) - Remove unused devDependencies ts-node and @yarnpkg/pnpify - Log replay-store initialisation warning on startup - Surface replay-store reset risk prominently in README production notes - Add integration tests for POST /verify (valid, invalid, replayed)
smeinecke
force-pushed
the
followup-fixes
branch
from
June 18, 2026 13:16
8b7c866 to
b829998
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes configuration gaps, removes dead code, cleans dependencies, surfaces replay-store behaviour, and adds a privacy-preserving POST /verify endpoint.
Changes
if (config.hmacKey === "$ecret.key")check is unreachable becauseparseApiConfignow enforces a 32-character minimum.EXPIREMINUTES,MAXRECORDS, andPORTare now passed through with defaults, fixing silent misconfiguration.ts-nodeand@yarnpkg/pnpify; neither is referenced in any script or config.application/jsonwith{ "altcha": string }. KeepsGET /verifyfor backward compatibility. Demo proxy updated to use POST, eliminating the token from API-side access logs.