Security validations, Compose hardening, integration tests, and DX improvements - #1
Merged
Merged
Conversation
…improvements
- Enforce minimum SECRET length (32 chars) in parseApiConfig
- Validate ALGORITHM against PBKDF2 whitelist (SHA-256/384/512)
- Return distinguishable JSON error bodies from /verify:
{ error: "invalid" } vs { error: "replayed" }
- Make demo service opt-in via Compose profile (--profile demo)
- Add restart: unless-stopped and resource limits to compose.yaml
- Add HTTP-level integration tests for api-app.ts (native fetch)
- Move test glob to bunfig.toml for shell-independent discovery
- Add lightweight request logging middleware (disabled in test)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses real gaps in configuration validation, deployment defaults, test coverage, and developer experience.
Security & correctness
Production & deployment
Test coverage
Developer experience