lf_interop_youtube.py: Added platform specific path for youtube automation.#310
Open
Amaresh-Candela wants to merge 1 commit into
Open
lf_interop_youtube.py: Added platform specific path for youtube automation.#310Amaresh-Candela wants to merge 1 commit into
Amaresh-Candela wants to merge 1 commit into
Conversation
Owner
|
Why do you need absolute paths? Can you not use ./local/ so that it will work in case someone installs LANforge in a non-standard location? |
Author
|
Yes, Ben. I initially thought we would continue using the absolute paths since our current deployments use the standard LANforge installation directories. However, I realize this would cause issues if LANforge is installed in a different location. I'll update the implementation to use relative paths instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lf_interop_youtube.py: Add platform-specific paths for YouTube automation scripts
-->Define absolute directory paths for Windows, Linux, and macOS real applications.
-->Update generic endpoint creation to use these platform-specific paths for youtube_stream.bat and ctyt.bash.
-->Fix argument quoting and improve formatting in the command string for Android devices.
Tested on macos(Macs-Air.ctinb.candelatechindia).
Verified CLI: python3 lf_interop_youtube.py
--mgr 192.168.244.97
--url "https://youtu.be/BHACKCNDMW8?si=psTEUzrc77p38aU1"
--duration 1
--res 1080p
--upstream_port 1.1.eth1