Repository navigation
Conversation
#16) Fixes how the backup screens look and navigate on Frappe v16. **Dark mode** In dark mode the Backup Control page's cards and snapshot table rendered white, their text barely visible, and the selected day in the schedule editor was dark on dark. - **Cards and table:** Frappe v16 themes only its own `.frappe-card`; Bootstrap's `.card` compiles to `background-color: #fff`. The page's cards now use the desk's `--card-bg` and `--border-color`. - **Day buttons:** use Frappe's `btn-primary` / `btn-default` instead of custom colors (`--gray-300`, and `--fg-color` text on `--primary-color`, which is dark on dark). **Sidebar, breadcrumbs and desk icon** - **Two sidebars:** the workspace was named "Restic Backups" while the module is "Restic Backup". v16 generates a sidebar for every module that has none named after it, so the doctypes got a generated "Restic Backup" sidebar and the page got "Restic Backups". The workspace is now named after the module, and the app ships its own "Restic Backup" sidebar (Backup Control, Backup Runs, Backup Settings) and desk icon. A patch removes the entries named "Restic Backups". - **Stale sidebar:** v16 chooses a page's sidebar from the module of the last doctype opened, so opening Backup Control from another app (for example through Ctrl+K) kept that app's sidebar until reload. The page now chooses its sidebar again when shown. - **Breadcrumbs:** the runs list and settings no longer replace their breadcrumb with "Backup Control", and the page no longer adds "Setup". Their "Backup Control" buttons stay. - **Desk icon:** an original solid and subtle icon. The Docker suite passes on v16 and v15. Checked in the browser on a copy of production: every route to the backup screens now shows the one "Restic Backup" sidebar.
Contributor
Author
|
🎉 This PR is included in version 0.1.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge (not squash) to release. The version comes from the fix/feat commits below.