Skip to content

fix: theme, sidebar and desk icon for the backup screens on Frappe v16 - #16

Merged
tulayha merged 2 commits into
developfrom
fix/dark-mode
Sep 29, 2026
Merged

tulayha merged 2 commits into
developfrom
fix/dark-mode

Conversation

@tulayha

@tulayha tulayha commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Fixes how the backup screens look and navigate on Frappe v16.

Dark mode

In dark mode the Backup Control page's cards and snapshot table rendered white, their text barely visible, and the selected day in the schedule editor was dark on dark.

  • Cards and table: Frappe v16 themes only its own .frappe-card; Bootstrap's .card compiles to background-color: #fff. The page's cards now use the desk's --card-bg and --border-color.
  • Day buttons: use Frappe's btn-primary / btn-default instead of custom colors (--gray-300, and --fg-color text on --primary-color, which is dark on dark).

Sidebar, breadcrumbs and desk icon

  • Two sidebars: the workspace was named "Restic Backups" while the module is "Restic Backup". v16 generates a sidebar for every module that has none named after it, so the doctypes got a generated "Restic Backup" sidebar and the page got "Restic Backups". The workspace is now named after the module, and the app ships its own "Restic Backup" sidebar (Backup Control, Backup Runs, Backup Settings) and desk icon. A patch removes the entries named "Restic Backups".
  • Stale sidebar: v16 chooses a page's sidebar from the module of the last doctype opened, so opening Backup Control from another app (for example through Ctrl+K) kept that app's sidebar until reload. The page now chooses its sidebar again when shown.
  • Breadcrumbs: the runs list and settings no longer replace their breadcrumb with "Backup Control", and the page no longer adds "Setup". Their "Backup Control" buttons stay.
  • Desk icon: an original solid and subtle icon.

The Docker suite passes on v16 and v15. Checked in the browser on a copy of production: every route to the backup screens now shows the one "Restic Backup" sidebar.

@tulayha tulayha changed the title fix: follow the desk theme on the backup control page fix: theme, sidebar and desk icon for the backup screens on Frappe v16 Sep 29, 2026
@tulayha
tulayha merged commit f5b8ce1 into develop Sep 29, 2026
6 checks passed
@tulayha
tulayha deleted the fix/dark-mode branch September 29, 2026 21:56
@tulayha

tulayha commented Sep 29, 2026

Copy link
Copy Markdown
Contributor Author

🎉 This PR is included in version 0.1.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant