Start building as a shared library on Windows (DLL)#67
Open
wravery wants to merge 7 commits intographql:masterfrom
Open
Start building as a shared library on Windows (DLL)#67wravery wants to merge 7 commits intographql:masterfrom
wravery wants to merge 7 commits intographql:masterfrom
Conversation
…xbison in the program path
wravery
commented
Jul 25, 2018
wravery
changed the title
Author
|
BTW, here's what I built with it: cppgraphqlgen. 😁 |
swolchok
reviewed
Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a potential fix for Issue #39. It depends on having python2 and winflexbison in the program path because the output of flex and bison is a little different with the --wincompat flag. We can't just use the checked in versions of those files on Windows.
Alternatively, Microsoft/vcpkg can acquire those tools on demand for Windows. I have a pull request to that project (#3953) to add a port for this library, it patches the CMakeList.txt file to add these tools to the path without requiring a separate install on Windows. The same port works on the Linux version of vcpkg as well.