Skip to content

[GAP-10] Add equivalent selection conflict validation rule#48

Merged
magicmark merged 1 commit into
graphql:mainfrom
magicmark:gap-10-equivalent-selection-validation
Jun 2, 2026
Merged

[GAP-10] Add equivalent selection conflict validation rule#48
magicmark merged 1 commit into
graphql:mainfrom
magicmark:gap-10-equivalent-selection-validation

Conversation

@magicmark
Copy link
Copy Markdown
Contributor

@magicmark magicmark commented Jun 2, 2026

Adds a validation rule requiring that equivalent selections (fields resolving to the same response position) must not have conflicting @mock usage. If any equivalent selection uses @mock, all must use it with the same arguments.

Discussed in https://discord.com/channels/625400653321076807/1507064206241956052

@magicmark magicmark force-pushed the gap-10-equivalent-selection-validation branch 5 times, most recently from 47ae3fc to 2169307 Compare June 2, 2026 16:12
…ctions

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@magicmark magicmark force-pushed the gap-10-equivalent-selection-validation branch from 2169307 to 121a0bf Compare June 2, 2026 16:17
@magicmark magicmark marked this pull request as ready for review June 2, 2026 16:18
@magicmark magicmark merged commit be2df21 into graphql:main Jun 2, 2026
2 checks passed
Copy link
Copy Markdown
Contributor

@rebello95 rebello95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants