chore: move all schema version crud logic from legacy storage module to dedicated class#8029
Draft
chore: move all schema version crud logic from legacy storage module to dedicated class#8029
Conversation
…to dedicated class
Contributor
Contributor
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors schema version management by migrating database logic from the legacy storage module to a new SchemaVersionStore class. Feedback highlights critical regressions in schema coordinate tracking during subgraph deletion and version creation. Additionally, a logic error in ResourceSelector incorrectly allows non-composable versions, and a security vulnerability was identified in SchemaManager where schema version lookups are no longer properly scoped to a target, potentially leading to unauthorized access.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Storage module toooo big; we want to add more logic due to graph variants (#7821) and promotion (#4021); thus we break it down
Description
Introduces a new class
SchemaVersionStoreand moves all schema version related crud operations from the legacyStorageclass over there.