Fix test_standard_finder failure in Python 3.13#2904
Merged
Conversation
Co-authored-by: deniszh <1227222+deniszh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [2872] Fix issue with Graphite web application
Fix open redirect vulnerability in URL shortener
Mar 17, 2026
deniszh
approved these changes
Mar 17, 2026
Co-authored-by: deniszh <1227222+deniszh@users.noreply.github.com>
Copilot
AI
changed the title
Fix open redirect vulnerability in URL shortener
Fix test_standard_finder failure in Python 3.13
Mar 17, 2026
deniszh
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Python 3.13,
Mock.call_countbecame a read-only property computed fromcall_args_list, somock.call_count = 0no longer resets the counter — it silently has no effect. This caused accumulated scandir call counts to bleed across test steps, producing5 != 1at the{foo}.bar.*assertion (4 calls from the prior*.ba?.{baz,foo}step + 1 = 5).Changes
tests/test_finders.py: Replace all 20 occurrences ofscandir_mock.call_count = 0withscandir_mock.reset_mock(), which correctly resets call tracking across all Python versions.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.