Repository navigation
Apply the order scope to the selected-orders export and delete - #1023
Merged
Merged
Conversation
ExportExcelSelected and DeleteSelected took the order ids from the request and acted on every order found. They now skip orders the staff member's scope does not cover, as PdfInvoiceSelected already does, so a Sales Manager exports and deletes only their sales employees' orders.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Comment on lines
+109
to
+111
| foreach (var order in await OrderService.GetOrdersByIds(ids)) | ||
| if (await Scope.HasAccess(order)) | ||
| orders.Add(order); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: bugfix
Issue
The order list,
ExportExcelAllandPdfInvoiceSelectedapply the staff member's order scope (IAdminDataScope<Order>).ExportExcelSelectedandDeleteSelectedin the AdminOrderControllerdid not, so the bulk actions did not follow the same rule as the rest of the order screens.Solution
Both actions keep only the orders
scope.HasAccessallows, the same check asPdfInvoiceSelected. Nothing changes for administrators.Tests:
OrderControllerScopeTests.No new resources, settings or migrations.
Breaking changes
None.
Testing
Unit tests pass:
Grand.Web.Admin.Tests(1865).