Skip to content

Feature: Add job timeout option to datasource#450

Open
nsmorales wants to merge 4 commits intografana:mainfrom
nsmorales:feature/job_timeout
Open

Feature: Add job timeout option to datasource#450
nsmorales wants to merge 4 commits intografana:mainfrom
nsmorales:feature/job_timeout

Conversation

@nsmorales
Copy link
Copy Markdown

What this PR does / why we need it:
We have external tables which do not report how many bytes a query will scan. To attempt to control cost we can use JobTimeout in QueryConfig to limit how long a job is allowed to execute for.

A new configuration option under Additional Settings has been added to.

If I missed anything please let me know.

@nsmorales nsmorales requested a review from a team as a code owner April 3, 2026 21:07
@cla-assistant
Copy link
Copy Markdown

cla-assistant Bot commented Apr 3, 2026

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link
Copy Markdown

cla-assistant Bot commented Apr 3, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sasklacz
Copy link
Copy Markdown
Contributor

Can we add a test ? By quick looking looks like we can send a negative timeout ?

@nsmorales
Copy link
Copy Markdown
Author

Can we add a test ? By quick looking looks like we can send a negative timeout ?

Hey.

I have added a test and have clamped the value so it doesn't allow negative values. Let me know if this is what you had in mind or if additional test in other parts of the code are needed.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants