Remove unused httpclient5 dependency from buildSrc - #412
Merged
Conversation
The dependency was added in 87d4518 for BintrayTask, which talked to the Bintray REST API. Bintray publishing was removed in 2db714e, but the dependency declaration was left behind. Nothing in buildSrc has referenced org.apache.hc since then, so this only added weight to the build classpath and produced recurring dependabot bumps. Dependency verification is pruned accordingly: the trusted keys for org.apache.httpcomponents, org.slf4j:slf4j-api and commons-codec covered httpclient5 and its transitives only, and are dropped along with their keyring entries. Note that VersioningPlugin imports org.slf4j.Logger, which used to be resolved transitively via httpclient5. It now comes from gradleApi(), so buildSrc still compiles from a clean state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dependency was added in 87d4518 for BintrayTask, which talked to the Bintray REST API. Bintray publishing was removed in 2db714e, but the dependency declaration was left behind. Nothing in buildSrc has referenced org.apache.hc since then, so this only added weight to the build classpath and produced recurring dependabot bumps.
Dependency verification is pruned accordingly: the trusted keys for org.apache.httpcomponents, org.slf4j:slf4j-api and commons-codec covered httpclient5 and its transitives only, and are dropped along with their keyring entries.