Deduplicate triangle-triangle intersection code#86
Open
Garrett-R wants to merge 2 commits intogradientspace:masterfrom
Open
Deduplicate triangle-triangle intersection code#86Garrett-R wants to merge 2 commits intogradientspace:masterfrom
Garrett-R wants to merge 2 commits intogradientspace:masterfrom
Conversation
Author
|
I also added my project to the "Projects using g3Sharp" list, but let me know if you want me to drop that commit. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed there were 2 functions with nearly identical code. Two small differences:
refusages, avoiding making copies. I took this oneTypewhich I've maintained.This is a pure refactor, API and functionality should be the same.