Land the twenty review reports in documentation/audit/ - #271
Merged
Conversation
…n/audit/ Vingt relectures indépendantes du cœur, du bundle Symfony et du plugin Sylius, menées le 3 septembre 2026 sur main à 8fdc5ec, plus leur synthèse. Les grilles sont nommées par leur axe de relecture. Aucun nom ni profil de personne n'apparaît : ce sont des axes d'expertise, pas des auteurs, et une opinion attribuée à quelqu'un qui ne l'a pas émise n'aurait rien à faire dans un dépôt. Seules subsistent deux références au paquet Composer webmozart/assert, dans une ligne « Amont » où elles citent une bibliothèque, pas une personne. Le README porte la méthode, le périmètre — dont l'exclusion des 680 fichiers protobuf générés du pont Temporal — et une section sur ce qu'un audit de code ne peut pas voir, avec les exemples que les issues ouvertes en donnent. Deux notes d'édition corrigent une surestimation du rapport sur les tests, reprise dans la synthèse : le statut « implemented for all four ports » de DUR041 était exact des ports. Ce qui était faux, ce sont les deux énoncés au présent sur les adaptateurs Temporal, repris en #270. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
La relecture croisée des PR a trouvé, dans ce versement, deux rapports qui s'appuient sur des faits incompatibles. `13-documentation.md` C3 affirmait que le mot « Psalm » n'apparaissait qu'une seule fois dans tout le dépôt — or `psalm.xml`, `psalm-baseline.xml`, `psalm-magento.xml` et deux passages de `.github/workflows/ci.yml` le portent, et `07-compatibilite-statique.md` consacre un constat entier, chronologie `git log` à l'appui, à la baseline Psalm. Le constat de fond tient : le `suggest` ne cite qu'une extension, et l'ADR renvoyé est le mauvais. C'est sa preuve qui était fausse. Elle est remplacée par ce qui est vérifiable — aucun paquet d'extension Psalm n'existe ici — et la distinction entre l'outil, bien présent, et l'extension annoncée, qui n'existe pas, est écrite. Le README porte la note d'édition. Un audit qui se corrige en silence demande qu'on le croie sur parole une deuxième fois. Reste entière, et elle n'est pas à moi : la place de ces vingt-deux fichiers. Ils sont en français sous `documentation/`, que WA001 réserve à l'anglais, et aucune des trois cartes du dépôt — `INDEX.md`, `LIFECYCLE.md`, `HUGO.md` — ne connaît `documentation/audit/`. Le mount Hugo (`hugo.toml:42-44`) les tient hors du site publié, donc rien ne fuit ; c'est une décision de convention, pas un défaut. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
gplanchat
enabled auto-merge
September 4, 2026 00:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation only — 22 files in
documentation/audit/, no code, no tests.What this is
Twenty independent reviews of the core, the Symfony bundle and the Sylius plugin, carried out on 3 September 2026 against
mainat8fdc5ec4, plus their synthesis and an index.Each axis was reviewed separately, without the reviews seeing one another. That is what makes the overlaps usable: four axes reach the hard-coded
/adminroute by four different paths, three reach the profiler running in production, two reach thesideEffect()hole.Naming
The grids are named by their review axis, never by a person —
01-coherence-symfony.md,15-messenger.md,19-tests.md. These are areas of expertise, not authors: an opinion attributed to someone who did not voice it has no place in a repository.Verified: no name and no account handle remains in the 22 files. Two occurrences of
webmozart/assertremain, in an Upstream line where they cite a Composer package and its documentation — a library, not a profile.Contents
README.md— method, scope, index of the twenty axes, and a section "What the audit could not see".00-synthese.md— verdict, 6 blockers, 43 deduplicated major findings, and what was verified as sound.01-…through20-…— one report per axis, eight findings maximum, each with its verifiedfile:line, its upstream reference and its fix.The scope explicitly excludes the 680 generated protobuf files of the Temporal bridge — 94 hand-written files out of 774 — as well as the Laravel and Magento packages.
Two editorial notes
The report on tests accused DUR041 of three false statements; there were only two. The "implemented for all four ports" status is accurate of the ports — all four do have their suite. What was false were the two present-tense statements about the Temporal adapters, plus the docblock of
EventStoreReplayConformanceTestCase. The rest of the finding holds, and its count of three affected adapters is correct.The correction is placed as an editorial note in the report and reworded in the synthesis, rather than by rewriting the original text: a report is a dated snapshot, and what it said is part of what it is.
What these reports are not
A list of accepted tasks. Only two follow-ups are under way at this stage — #270 (DUR041) and #269 (
backend-data-parity) — and the README says so.Editorial note — 2026-09-04, after cross-review of the open PRs
Two reports in this batch relied on incompatible facts.
13-documentation.mdC3 claimed the word "Psalm" appeared only once in the whole repository — yetpsalm.xml,psalm-baseline.xml,psalm-magento.xmland two passages of.github/workflows/ci.ymlcarry it, and07-compatibilite-statique.md, in this same batch, devotes a whole finding to the Psalm baseline.The substance of the finding holds: the
suggestcites only one extension, and the ADR it points at is the wrong one. It was its proof that was false. That proof is retracted, replaced by what is verifiable — no Psalm extension package exists here — and the README carries the editorial note. An audit that corrects itself quietly is asking to be taken on trust a second time.Still open, and not mine to settle: where these twenty-two files belong. They are in French under
documentation/, which WA001 reserves for English, and none of the repository's three maps —INDEX.md,LIFECYCLE.md,HUGO.md— knows aboutdocumentation/audit/. The Hugo mount (hugo.toml:42-44) keeps them off the published site, so nothing leaks; this is a convention decision, not a defect.