Make invalid link test less brittle - #23
Open
aceroer wants to merge 40 commits into
Open
Conversation
Co-authored-by: Stan B. <godstanis@gmail.com>
Co-authored-by: Stan B. <godstanis@gmail.com>
Co-authored-by: Stan B. <godstanis@gmail.com>
Author
|
Closing this for now. I am going to pursue a separate experimental client direction instead of asking upstream to carry this small compatibility patch. |
aceroer
force-pushed
the
codex/fix-invalid-link-test
branch
from
July 29, 2026 15:37
bbffbb8 to
9a5143a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The current test expects the dependency error text "invalid protocol type", but current xray-knife returns "invalid xray protocol" for the same invalid link. The production code still wraps both as "invalid xray link", so asserting that stable context keeps the test focused on the behavior owned by this project.
Test