Store bounce details on delivery#2082
Open
stephencdaly wants to merge 4 commits intomainfrom
Open
Conversation
We want to send a daily notification of any bounced submission emails to the admins for a form. In the notification email, we want to include different content depending on whether we can identify the bounce as a hard or soft bounce, with the scope to be more specific in the future for different bounce types. Add a `failure_details` jsonb column to the deliveries table to store additional failure details when a delivery fails.
stephencdaly
force-pushed
the
store-bounce-details-on-submission
branch
2 times, most recently
from
1400218 to
2f7d1ec
Compare
When handling a bounce, store the JSON blob continaing detailed information about the bounce on the delivery. This will allows us to inspect this information when sending daily notification emails about bounces to form admins. Update the specs to remove the additional "when there is a bounce object with detailed information" contexts and instead include the assertions that we log the bounce details in the existing contexts.
stephencdaly
force-pushed
the
store-bounce-details-on-submission
branch
from
2f7d1ec to
40f6f14
Compare
Contributor
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2082.submit.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/CsEqMtDL
We want to send a daily notification of any bounced submission emails to the admins for a form. In the notification email, we want to include different content depending on whether we can identify the bounce as a hard or soft bounce, with the scope to be more specific in the future for different bounce types.
Add a
failure_detailsjsonb column to the deliveries table to store additional failure details when a delivery fails.Things to consider when reviewing