Add API endpoint to get the group for a form#2748
Conversation
Add an API endpoint that returns the group details for the form with the given ID. This includes the group admin users, and the organisation details including the organisation admin users as embedded resources. This endpoint will be used by forms-runner to get the group and organisation details for the form and the contact details for the group and organisation admin users in order to send email notifications when submissions bounce.
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2748.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
| let(:headers) { { "ACCEPT": "application/json" } } | ||
|
|
||
| describe "GET /show" do | ||
| describe "GET #show" do |
There was a problem hiding this comment.
I think what was there before was correct, based on the other request specs in this repo, and the template in rspec-rails
| describe "GET #show" do | |
| describe "GET /show" do |
There was a problem hiding this comment.
Hmm actually I think neither are consistent with how we usually do it elsewhere.
Looks like we do describe "GET /path" or describe "#action"
There was a problem hiding this comment.
Oh yeah you're right /show is an action not a path
What problem does this pull request solve?
Trello card: https://trello.com/c/CsEqMtDL
Add an API endpoint that returns the group details for the form with the given ID. This includes the group admin users, and the organisation details including the organisation admin users as embedded resources.
This endpoint will be used by forms-runner to get the group and organisation details for the form and the contact details for the group and organisation admin users in order to send email notifications when submissions bounce.
Things to consider when reviewing