Display multiple branches on add/edit page#2744
Merged
Conversation
b8da23b to
1562c70
Compare
lfdebrux
reviewed
May 1, 2026
lfdebrux
reviewed
May 1, 2026
lfdebrux
reviewed
May 1, 2026
036effb to
5771e6b
Compare
lfdebrux
reviewed
May 6, 2026
lfdebrux
previously approved these changes
May 6, 2026
This is based on the Group's multiple_branches_enabled feature flag - so if this is toggled off, then it will use the original add and edit page view. When the flag is turned on for the group, the display logic assumes that the form has been created using the new Routes process, and will not be particularly compatible with forms that have been created using the old routing pages (although it might work if the routing is relatively simple). There is no validation displayed for these changes, as we're not ready to start deciding how to validate the new multiple-branch routes.
5771e6b to
95ae7a4
Compare
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2744.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
lfdebrux
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on the Group's multiple_branches_enabled feature flag - so if this is toggled off, then it will use the original add and edit page view.
When the flag is turned on for the group, the display logic assumes that the form has been created using the new Routes process, and will not be particularly compatible with forms that have been created using the old routing pages (although it might work if the routing is relatively simple).
There is no validation displayed for these changes, as we're not ready to start deciding how to validate the new multiple-branch routes.
I've removed the edit links for now, we'll need to add them in once we've got the questions listed out on the routes page, as they should be anchored links.
What problem does this pull request solve?
https://trello.com/c/IgUz33Ml/3070-make-edit-questions-list-display-with-new-routes
Things to consider when reviewing