Skip to content

Display multiple branches on add/edit page#2744

Merged
SamJamCul merged 2 commits intomainfrom
multiple-branches-questions-page
May 6, 2026
Merged

Display multiple branches on add/edit page#2744
SamJamCul merged 2 commits intomainfrom
multiple-branches-questions-page

Conversation

@SamJamCul
Copy link
Copy Markdown
Contributor

This is based on the Group's multiple_branches_enabled feature flag - so if this is toggled off, then it will use the original add and edit page view.

When the flag is turned on for the group, the display logic assumes that the form has been created using the new Routes process, and will not be particularly compatible with forms that have been created using the old routing pages (although it might work if the routing is relatively simple).

There is no validation displayed for these changes, as we're not ready to start deciding how to validate the new multiple-branch routes.

I've removed the edit links for now, we'll need to add them in once we've got the questions listed out on the routes page, as they should be anchored links.

What problem does this pull request solve?

https://trello.com/c/IgUz33Ml/3070-make-edit-questions-list-display-with-new-routes

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@SamJamCul SamJamCul force-pushed the multiple-branches-questions-page branch 3 times, most recently from b8da23b to 1562c70 Compare April 30, 2026 15:34
Comment thread app/components/page_list_component/view.html.erb Outdated
Comment thread app/components/page_list_component/view.html.erb Outdated
Comment thread app/components/page_list_component/view.rb Outdated
@SamJamCul SamJamCul force-pushed the multiple-branches-questions-page branch 4 times, most recently from 036effb to 5771e6b Compare May 5, 2026 16:43
Comment thread spec/components/page_list_component/page_list_component_preview.rb
lfdebrux
lfdebrux previously approved these changes May 6, 2026
SamJamCul added 2 commits May 6, 2026 09:31
This is based on the Group's multiple_branches_enabled feature flag - so
if this is toggled off, then it will use the original add and edit page
view.

When the flag is turned on for the group, the display logic assumes that
the form has been created using the new Routes process, and will not be
particularly compatible with forms that have been created using the old
routing pages (although it might work if the routing is relatively
simple).

There is no validation displayed for these changes, as we're not ready
to start deciding how to validate the new multiple-branch routes.
@SamJamCul SamJamCul force-pushed the multiple-branches-questions-page branch from 5771e6b to 95ae7a4 Compare May 6, 2026 08:31
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2744.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@SamJamCul SamJamCul added this pull request to the merge queue May 6, 2026
Merged via the queue into main with commit 40ea22e May 6, 2026
3 checks passed
@SamJamCul SamJamCul deleted the multiple-branches-questions-page branch May 6, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants