Add separate make live confirmations for each language#2717
Open
DavidBiddle wants to merge 6 commits intomainfrom
Open
Add separate make live confirmations for each language#2717DavidBiddle wants to merge 6 commits intomainfrom
DavidBiddle wants to merge 6 commits intomainfrom
Conversation
75eb02a to
448e42f
Compare
a0e75c4 to
821b8c7
Compare
821b8c7 to
16a4558
Compare
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2717.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/VUw58sEk/2891-add-confirmation-pages-for-english-welsh-when-a-form-version-has-been-made-live
Adds new pages for making English and Welsh live for the first time separately.
These pages will be made visible in the tasklist in a future ticket.
Screenshots
View for making English live:
English confirmation (when form's Welsh translation is not ready to be made live)
English confirmation (when form's Welsh translation is ready to be made live)
View for making English live:
Welsh confirmation
Testing instructions
You won't be able to access the new views through the UI, but you can get there by going directly to the routes:
/forms/{form_id}/make-live/en/forms/{form_id}/make-live/cyThings to consider when reviewing