Skip to content

Add separate make live confirmations for each language#2717

Open
DavidBiddle wants to merge 6 commits intomainfrom
add-separate-make-live-confirmations-for-each-language
Open

Add separate make live confirmations for each language#2717
DavidBiddle wants to merge 6 commits intomainfrom
add-separate-make-live-confirmations-for-each-language

Conversation

@DavidBiddle
Copy link
Copy Markdown
Contributor

@DavidBiddle DavidBiddle commented Apr 22, 2026

What problem does this pull request solve?

Trello card: https://trello.com/c/VUw58sEk/2891-add-confirmation-pages-for-english-welsh-when-a-form-version-has-been-made-live

Adds new pages for making English and Welsh live for the first time separately.

These pages will be made visible in the tasklist in a future ticket.

Screenshots

View for making English live:

image

English confirmation (when form's Welsh translation is not ready to be made live)

image

English confirmation (when form's Welsh translation is ready to be made live)

image

View for making English live:

image

Welsh confirmation

image

Testing instructions

You won't be able to access the new views through the UI, but you can get there by going directly to the routes:

  • /forms/{form_id}/make-live/en
    • your form will need to:
      • be ready to be made live
      • not have a live or archived English version
      • not have a live welsh version
  • /forms/{form_id}/make-live/cy
    • your form will need to:
      • be ready to be made live
      • have a live English version
      • not have a live welsh version

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@DavidBiddle DavidBiddle force-pushed the add-separate-make-live-confirmations-for-each-language branch 8 times, most recently from 75eb02a to 448e42f Compare April 29, 2026 08:30
@DavidBiddle DavidBiddle force-pushed the add-separate-make-live-confirmations-for-each-language branch 8 times, most recently from a0e75c4 to 821b8c7 Compare May 1, 2026 15:11
@DavidBiddle DavidBiddle marked this pull request as ready for review May 5, 2026 14:57
@DavidBiddle DavidBiddle force-pushed the add-separate-make-live-confirmations-for-each-language branch from 821b8c7 to 16a4558 Compare May 5, 2026 14:57
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2717.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant