Skip to content

Add security CI/CD pipeline for GitHub Actions in addition to existing security measures#29

Merged
Jamestth merged 8 commits into
mainfrom
feat/add-security-cicd
Jun 4, 2026
Merged

Add security CI/CD pipeline for GitHub Actions in addition to existing security measures#29
Jamestth merged 8 commits into
mainfrom
feat/add-security-cicd

Conversation

@Jamestth
Copy link
Copy Markdown
Contributor

@Jamestth Jamestth commented Jun 3, 2026

Summary

  • Add a new security.yml GitHub Actions workflow replicating GitLab CI security scanning (secret detection, dependency scanning, SAST)
  • Improve error handling in LogicalTypeOptionsCheckReference by replacing assert statements with explicit RuntimeError for clearer debugging in production

Changes

Security workflow (.github/workflows/security.yml):

  • Secret detection — TruffleHog scans commit history for leaked credentials (verified + unknown results). No license required.
  • SAST — Semgrep with p/python, p/bandit, and p/secrets rulesets. Fails the job on findings (--error). No token required.
  • Dependency review — Blocks PRs that introduce high-severity vulnerable dependencies (fail-on-severity: high)
    All three jobs are configured to fail on findings.

Runs on pushes to main and on pull requests.

Error handling fix (src/vowl/contracts/check_reference_generated.py):

  • Replace bare assert pattern is not None with RuntimeError that includes the failing value, so issues are surfaced in production rather than silently passing when Python optimizations are enabled (-O).

@Jamestth Jamestth requested a review from a team June 3, 2026 06:55
@Jamestth Jamestth merged commit 1479235 into main Jun 4, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants