fix: remove GitHub VCS repo and make token optional#146
Open
jackwrfuller wants to merge 1 commit into
Open
Conversation
jackwrfuller
force-pushed
the
remove-dependency-on-github-token
branch
from
810050d to
7a5a803
Compare
jackwrfuller
force-pushed
the
remove-dependency-on-github-token
branch
from
1a0ecf6 to
0e806d0
Compare
jackwrfuller
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Internal ticket: GOVCMS-14815
This PR removes the github vcs repository since it is redundant, and also makes the setting of the
GOVCMS_GITHUB_TOKENoptional at build time.This token is required because Packagist functions only as a metadata index and does not host packages directly. Composer frequently falls back to the GitHub HTTP API to resolve refs, fetch composer.json files, and download package distributions for non-Drupal dependencies (Symfony, Doctrine, Guzzle, etc.). Anonymous GitHub API access is limited to 60 requests per hour per IP, which is sufficient for local development but causes rate limit failures in shared environments (like GovCMS) where multiple builds share the same egress IP.
GovCMS sets this variable in production on project provisioning so customers do not have to perform this task. Locally however, there is no need for them to set this token.