[GOVCMS-13537] docker-compose: Remove unused arguments GITHUB_TOKEN, COMPOSER_AUTH#551
Open
Randominty wants to merge 1 commit into
Open
[GOVCMS-13537] docker-compose: Remove unused arguments GITHUB_TOKEN, COMPOSER_AUTH#551Randominty wants to merge 1 commit into
Randominty wants to merge 1 commit into
Conversation
Contributor
|
Amazing work @Randominty! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal Ticket: https://osbfinance.atlassian.net/browse/GOVCMS-13537
While evaluating the build pipeline for any potential leaks of sensitive tokens, some unused argument assignments were found in the docker-compose.yml file. These do not present a risk to the build pipeline as there are no corresponding
ARGdefinitions inDockerfile.govcmsorDockerfile.test, but still worth cleaning them up.These would appear to be relics of the old method before build secrets were used to authenticate for composer (#388).