feat!: get_recommend now returns array of Score with X-API-Version: 2#12
Merged
zhenghaoz merged 6 commits intogorse-io:mainfrom Mar 31, 2026
Merged
Conversation
added 6 commits
March 31, 2026 20:49
- Add getRecommendWithScores method that returns array of Score objects - Add requestWithHeaders helper method to support custom headers - Uses X-API-Version: 2 header to return scores - Related: gorse-io/gorse#1140
BREAKING CHANGE: get_recommend now returns array of Score objects instead of array of strings - Uses X-API-Version: 2 header to return scores
- Check that getRecommend returns array of Score instances - Verify each Score has non-empty id and score fields - Assert specific expected IDs: 315, 1432, 918 - Update testNonPersonalized to check Score properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: get_recommend now returns array of Score objects instead of array of strings
X-API-Version: 2header gorse#1140