fix(poll): suppress Sentry noise for self-healing hot-poll failures - #120
Merged
Merged
Conversation
Hot-poll fetch errors were reported to Sentry on every occurrence, even though retry/backoff already recovers from isolated network blips (e.g. TypeError: Failed to fetch) within a cycle or two. fetchHotData() and fetchHotPRStatus() now only capture to Sentry once consecutive failures cross HOT_POLL_SENTRY_THRESHOLD (3), keeping the existing console.warn/toast feedback for transient failures.
Adds coverage for the gating logic added in the prior commit: - fetchHotPRStatus respects the reportToSentry option (default off) - fetchHotData only reports once priorConsecutiveFailures reaches HOT_POLL_SENTRY_THRESHOLD, for both the PR-status and workflow-run fetch paths - End-to-end coordinator test drives 4 real failing cycles through fake timers, confirming consecutiveFailures actually threads from createHotPollCoordinator into fetchHotData across cycles and only the 4th (post-threshold) failure reports to Sentry
wgordon17
marked this pull request as ready for review
July 28, 2026 19:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeError: Failed to fetchagainst api.github.com) were reported to Sentry on every occurrence, even though retry/backoff already recovers within a cycle or twofetchHotData()/fetchHotPRStatus()now only capture to Sentry once consecutive failures cross a threshold (3), while keeping the existing console.warn/toast feedback for transient blips