Repository navigation
mv c/openssl => github.com/llarhub/openssl - #65
Merged
Merged
Conversation
There was a problem hiding this comment.
Review: clean package relocation
This PR removes the entire c/openssl package (18 files, 1822 deletions) as part of relocating it to github.com/llarhub/openssl. I reviewed it across code quality, performance, security, and documentation accuracy.
Verified the deletion is clean and complete:
- No broken imports — no file in the repo imports
github.com/goplus/lib/c/openssl, so the build won't break for any remaining package. - No dangling references — grep for
openssl/c/opensslacross.go,.md,.mod,.sum, and CI/config files returns zero matches (the onlyllarhubhit,README.md:8, is a pre-existing LLGo badge, unrelated to this change). - No partial-deletion artifacts — the
c/openssl/tree (including_wrap/openssl.cand all_demo/*) is fully removed; no empty dirs or orphaned files. - No stale docs —
README.mdis a badge-only header with no per-binding index, andc/llcppg.pubnever listed openssl, so no documentation or binding listing needs updating. - Security / performance — deletion-only change: no new attack surface and no hot-path dependency left behind. The deleted files were C-binding declarations (rsa/sha/hmac/md5/rand/bn/pem), containing no secrets.
No issues found. The change is a self-consistent, complete relocation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.