Skip to content

mv c/openssl => github.com/llarhub/openssl - #65

Merged
xushiwei merged 1 commit into
goplus:mainfrom
xushiwei:q
Oct 28, 2026
Merged

xushiwei merged 1 commit into
goplus:mainfrom
xushiwei:q

Conversation

@xushiwei

Copy link
Copy Markdown
Member

No description provided.

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: clean package relocation

This PR removes the entire c/openssl package (18 files, 1822 deletions) as part of relocating it to github.com/llarhub/openssl. I reviewed it across code quality, performance, security, and documentation accuracy.

Verified the deletion is clean and complete:

  • No broken imports — no file in the repo imports github.com/goplus/lib/c/openssl, so the build won't break for any remaining package.
  • No dangling references — grep for openssl / c/openssl across .go, .md, .mod, .sum, and CI/config files returns zero matches (the only llarhub hit, README.md:8, is a pre-existing LLGo badge, unrelated to this change).
  • No partial-deletion artifacts — the c/openssl/ tree (including _wrap/openssl.c and all _demo/*) is fully removed; no empty dirs or orphaned files.
  • No stale docs — README.md is a badge-only header with no per-binding index, and c/llcppg.pub never listed openssl, so no documentation or binding listing needs updating.
  • Security / performance — deletion-only change: no new attack surface and no hot-path dependency left behind. The deleted files were C-binding declarations (rsa/sha/hmac/md5/rand/bn/pem), containing no secrets.

No issues found. The change is a self-consistent, complete relocation.

@xushiwei
xushiwei merged commit 5493747 into goplus:main Oct 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant